Bug 241790
| Summary: | Fix broken --useOSLog option. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
Internally, --useOSLog=0 is represented as OSLogType::None. Options::dumpAllOptionsInALine() dumps this value as "none". When "none" is later passed back top Options::setOption(), it is rejected because useOSLog's parse function wasn't expecting "none" as an input string. The fix is to simply add "none" to the list of allowed input strings.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/1641
EWS
Committed r295677 (251682@main): <https://commits.webkit.org/251682@main>
Reviewed commits have been landed. Closing PR #1641 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/95558387>