Bug 241763
| Summary: | git-webkit pr sometimes produces unexpected results when merging titles of multiple commits | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=241762 | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Nikolas Zimmermann
I named a bug report "[LBSE] Add 'viewBox' support" (webkit.org/b/241762) and used git-webkit pr to create a PR, which was only named "[LBSE] Add '" (https://github.com/WebKit/WebKit/pull/1622).
There's a bug related to hyphens, I'll move on and fix the PR name but this might be relevant for others, so I'll open a ticket.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I think that you meant apostrophe, not hyphen - is that right?
Jonathan Bedard
This isn't about hyphens or apostrophes, it's about multiple commits in a PR. git-webkit is trying to craft a title that applies to all the commits in the PR (unsuccessfully, in this case). Basically, all those commits share "[LBSE] Add", so that's what we're titling the PR.
We can definitely improve how we name multi-commit PRs, although it's not obvious exactly what the title of a multi-commit PR should be, especially when commits have as diverse headers as the commits in this PR.
Radar WebKit Bug Importer
<rdar://problem/95941403>