Bug 241748
| Summary: | Align uniform*, WebGLMultiDraw, and GraphicsContextGLANGLE functions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Knyazev <lexa.knyazev> |
| Component: | WebGL | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, kbr, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 219140 | ||
Alexey Knyazev
* WebGL2RenderingContext::uniform* function signatures should have const qualifiers like their counterparts.
* WebGL2RenderingContext::uniform* function signatures should use rvalue references for typed arrays.
* WebGLMultiDraw should not redefine TypedList class.
* WebGLMultiDraw::multiDraw* function signatures should use rvalue references for typed arrays.
* WebGLRenderingContextBase::uniform1* should skip extra validation when using ANGLE.
* All draw and clear commands from GraphicsContextGLANGLE should end with checkGPUStatus.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed r295682 (251687@main): <https://commits.webkit.org/251687@main>
Reviewed commits have been landed. Closing PR #1616 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/95577796>