Bug 241734 – REGRESSION (r294902): Content with continuation leaves decoration bits behind when removed

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

<rdar://95308322>

[zalan]

Created attachment 460322 [details]
Patch

[zalan]

Created attachment 460333 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 460333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460333&action=review

> LayoutTests/fast/repaint/force-repaint-when-layer-is-destroyed.html:29
> +    result.innerText = internals.repaintRectsAsText().indexOf("8 8 140 126") != -1 ? "PASS" : "FAIL";

This seems fragile. Maybe use a more relaxed test?

[zalan]

Created attachment 460342 [details]
Patch

[zalan]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 460333 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=460333&action=review
> 
> > LayoutTests/fast/repaint/force-repaint-when-layer-is-destroyed.html:29
> > +    result.innerText = internals.repaintRectsAsText().indexOf("8 8 140 126") != -1 ? "PASS" : "FAIL";
> 
> This seems fragile. 
This is very precise, yes. It's the exact position/size of the box that needs repainting. I am open to suggestions, but block level boxes tend no to fluctuate their position/size.

[EWS]

Committed r295665 (251670@main): <https://commits.webkit.org/251670@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460342 [details].