Bug 241681

Summary:

Assorted build-time warnings fixes

Product:

WebKit

Reporter:

Claudio Saavedra <csaavedra>

Component:

New Bugs

Assignee:

Claudio Saavedra <csaavedra>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, keith_miller, macpherson, mark.lam, menard, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Claudio Saavedra 2022-06-16 05:46:44 PDT

Assorted build-time warnings fixes

Comment 1 Claudio Saavedra 2022-06-16 05:50:18 PDT

Created attachment 460270 [details]
Patch

Comment 2 Mark Lam 2022-06-16 07:50:45 PDT

Comment on attachment 460270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460270&action=review

> Source/JavaScriptCore/bytecode/Repatch.cpp:1818
> +                if (callCase.codeBlock()) {

Wrong fix.  The right thing to do is to use codeBlock in the body below.

Comment 3 Claudio Saavedra 2022-06-16 08:03:11 PDT

Comment on attachment 460270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460270&action=review

>> Source/JavaScriptCore/bytecode/Repatch.cpp:1818
>> +                if (callCase.codeBlock()) {
> 
> Wrong fix.  The right thing to do is to use codeBlock in the body below.

I simply followed what is done in the same method further down in the code, but OK.

Comment 4 Claudio Saavedra 2022-06-16 08:08:08 PDT

Created attachment 460271 [details]
Patch

Comment 5 Mark Lam 2022-06-16 09:14:49 PDT

Comment on attachment 460271 [details]
Patch

r=me

Comment 6 EWS 2022-06-16 22:27:05 PDT

Committed r295627 (251632@main): <https://commits.webkit.org/251632@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460271 [details].

Comment 7 Radar WebKit Bug Importer 2022-06-16 22:28:18 PDT

<rdar://problem/95358993>