Bug 241681

Summary: Assorted build-time warnings fixes
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: New BugsAssignee: Claudio Saavedra <csaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, keith_miller, macpherson, mark.lam, menard, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Claudio Saavedra
Reported 2022-06-16 05:46:44 PDT
Assorted build-time warnings fixes
Attachments
Patch (3.83 KB, patch)
2022-06-16 05:50 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Patch (3.83 KB, patch)
2022-06-16 08:08 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2022-06-16 05:50:18 PDT
Created attachment 460270 [details] Patch
Mark Lam
Comment 2 2022-06-16 07:50:45 PDT
Comment on attachment 460270 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460270&action=review > Source/JavaScriptCore/bytecode/Repatch.cpp:1818 > + if (callCase.codeBlock()) { Wrong fix. The right thing to do is to use codeBlock in the body below.
Claudio Saavedra
Comment 3 2022-06-16 08:03:11 PDT
Comment on attachment 460270 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460270&action=review >> Source/JavaScriptCore/bytecode/Repatch.cpp:1818 >> + if (callCase.codeBlock()) { > > Wrong fix. The right thing to do is to use codeBlock in the body below. I simply followed what is done in the same method further down in the code, but OK.
Claudio Saavedra
Comment 4 2022-06-16 08:08:08 PDT
Created attachment 460271 [details] Patch
Mark Lam
Comment 5 2022-06-16 09:14:49 PDT
Comment on attachment 460271 [details] Patch r=me
EWS
Comment 6 2022-06-16 22:27:05 PDT
Committed r295627 (251632@main): <https://commits.webkit.org/251632@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460271 [details].
Radar WebKit Bug Importer
Comment 7 2022-06-16 22:28:18 PDT
<rdar://problem/95358993>
Note You need to log in before you can comment on or make changes to this bug.