Summary: | AX: AccessibilityObject::insertText does not insert any text into password fields | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||||
Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tyler Wilcock
2022-06-14 14:09:22 PDT
Created attachment 460237 [details]
Patch
(In reply to Tyler Wilcock from comment #3) > Created attachment 460237 [details] > Patch --- a/Source/WebCore/accessibility/AccessibilityObject.cpp +++ a/Source/WebCore/accessibility/AccessibilityObject.cpp + bool isPasswordField = false; + if (auto* inputElement = dynamicDowncast<HTMLInputElement>(element)) + isPasswordField = inputElement->isPasswordField(); Can we use the override of isPasswordField() instead of recreating that logic here? Created attachment 460244 [details]
Patch
(In reply to Andres Gonzalez from comment #4) > (In reply to Tyler Wilcock from comment #3) > > Created attachment 460237 [details] > > Patch > > --- a/Source/WebCore/accessibility/AccessibilityObject.cpp > +++ a/Source/WebCore/accessibility/AccessibilityObject.cpp > > + bool isPasswordField = false; > + if (auto* inputElement = dynamicDowncast<HTMLInputElement>(element)) > + isPasswordField = inputElement->isPasswordField(); > > Can we use the override of isPasswordField() instead of recreating that > logic here? Fixed. Committed r295553 (251558@main): <https://commits.webkit.org/251558@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460244 [details]. |