Bug 241577
| Summary: | [GPU Process] [Filters] Remove SVGFilterBuilder | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Said Abou-Hallawa
After r295498, all the methods of SVGFilterBuilder became static. So let's remove it and move its methods to SVGFilter.
This change will make SVGFilter and CSSFilter be very similar regarding the layout and the creation. CSSFilter::create() and SVGFilter::create() are responsible of creating the filters. And CSSFilter::calculateOutsets() and SVGFilter::calculateOutsets() can help knowing how much outsets they need to draw correctly.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/1487
Radar WebKit Bug Importer
<rdar://problem/95074247>
EWS
Committed r295517 (251522@main): <https://commits.webkit.org/251522@main>
Reviewed commits have been landed. Closing PR #1487 and removing active labels.