Summary: | Set protections on MAP_ALIGNED platforms too for WTF::OSAllocator::tryReserveUncommittedAligned | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leonardo Taccari <iamleot+webkit-bugzilla> | ||||
Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, iamleot+webkit-bugzilla, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | Other | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=236460 | ||||||
Attachments: |
|
Description
Leonardo Taccari
2022-06-07 15:37:39 PDT
Created attachment 460075 [details] REGRESSION(247105@main): Set protections on MAP_ALIGNED platforms too Since the introduction of tryReserveUncommittedAligned() on platforms that have MAP_ALIGNED via 247105@main, reserved pages via that function never had the protections adjusted and will likely ends up in SIGSEGV. After this patch and https://bugs.webkit.org/show_bug.cgi?id=241386 is applied jsc should build and runs on NetBSD too without any further patches. Comment on attachment 460075 [details] REGRESSION(247105@main): Set protections on MAP_ALIGNED platforms too Mark it as ready for review. @Leonardo Also I recommend joining WebKit slack from https://webkit.org/getting-started/ And joining #jsc / #reviews channel. There are JSC reviewers you can ask for reviews :) Great suggestion! I'm there too now! :) Thank you very much Yusuke! Comment on attachment 460075 [details] REGRESSION(247105@main): Set protections on MAP_ALIGNED platforms too r=me Committed r295382 (251390@main): <https://commits.webkit.org/251390@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460075 [details]. |