Bug 241378

Summary: Implement CSSNumericValue.equals
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: CSSAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alex Christensen 2022-06-07 11:32:53 PDT 
...
Comment 1 Alex Christensen 2022-06-07 11:36:28 PDT 
Created attachment 460069 [details]
Patch
Comment 2 Darin Adler 2022-06-07 15:11:35 PDT 
Comment on attachment 460069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460069&action=review

> COMMIT_MESSAGE:6
> +This is an off-by-default experimental feature.

*What* is an off-by-default experimental feature? Nothing in this new code is conditional, so the experimental feature must be something this is building on.
Comment 3 Alex Christensen 2022-06-07 20:34:34 PDT 
The whole CSS typed om.  That's an explanation to any reviewers of why this is a super low risk change - it's all inaccessible in browsers by default.
Comment 4 Alex Christensen 2022-06-07 20:47:11 PDT 
(more specifically, CSSNumericValue.equals which is specified as EnabledBySetting in CSSNumericValue.idl)
Comment 5 Radar WebKit Bug Importer 2022-06-14 11:33:13 PDT 
<rdar://problem/95130832>
Comment 6 Chris Dumez 2022-06-21 12:45:53 PDT 
Comment on attachment 460069 [details]
Patch

r=me
Comment 7 EWS 2022-06-21 20:00:42 PDT 
Committed r295716 (251721@main): <https://commits.webkit.org/251721@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460069 [details].