Bug 241378 - Implement CSSNumericValue.equals
Summary: Implement CSSNumericValue.equals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-07 11:32 PDT by Alex Christensen
Modified: 2022-06-21 20:00 PDT (History)
9 users (show)

See Also:

Attachments
Patch (16.75 KB, patch)
2022-06-07 11:36 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-06-07 11:32:53 PDT 
...
Comment 1 Alex Christensen 2022-06-07 11:36:28 PDT 
Created attachment 460069 [details]
Patch
Comment 2 Darin Adler 2022-06-07 15:11:35 PDT 
Comment on attachment 460069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460069&action=review

> COMMIT_MESSAGE:6
> +This is an off-by-default experimental feature.

*What* is an off-by-default experimental feature? Nothing in this new code is conditional, so the experimental feature must be something this is building on.
Comment 3 Alex Christensen 2022-06-07 20:34:34 PDT 
The whole CSS typed om.  That's an explanation to any reviewers of why this is a super low risk change - it's all inaccessible in browsers by default.
Comment 4 Alex Christensen 2022-06-07 20:47:11 PDT 
(more specifically, CSSNumericValue.equals which is specified as EnabledBySetting in CSSNumericValue.idl)
Comment 5 Radar WebKit Bug Importer 2022-06-14 11:33:13 PDT 
<rdar://problem/95130832>
Comment 6 Chris Dumez 2022-06-21 12:45:53 PDT 
Comment on attachment 460069 [details]
Patch

r=me
Comment 7 EWS 2022-06-21 20:00:42 PDT 
Committed r295716 (251721@main): <https://commits.webkit.org/251721@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460069 [details].