| Summary: | [JSC][ARMv7] Don't save CSRs respected by the JIT ABI on VM entry | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geza Lore <glore> | ||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, xan.lopez | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Geza Lore
2022-06-07 07:56:34 PDT
Created attachment 460062 [details]
Patch
Comment on attachment 460062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460062&action=review r=me with comment fix up. > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:776 > + # but are not in RegisterSet::vmCalleeSaveRegisters() need to be saved here. > + # I.e.: Only those registers that are callee save in the C ABI, but are not > + # callee save in teh JIT ABI. nit: "here. I.e.: Only" -> "here i.e. only". /teh/the/ Created attachment 460118 [details]
Patch
Created attachment 460119 [details]
Patch
Committed r295416 (251422@main): <https://commits.webkit.org/251422@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460119 [details]. |