Bug 241369

Summary: [JSC][ARMv7] Don't save CSRs respected by the JIT ABI on VM entry
Product: WebKit Reporter: Geza Lore <glore>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, xan.lopez
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Geza Lore
Reported 2022-06-07 07:56:34 PDT
Patch incoming.
Attachments
Patch (2.35 KB, patch)
2022-06-07 08:59 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2022-06-09 02:56 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2022-06-09 02:58 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Geza Lore
Comment 1 2022-06-07 08:59:51 PDT
Created attachment 460062 [details] Patch
Mark Lam
Comment 2 2022-06-07 11:25:57 PDT
Comment on attachment 460062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460062&action=review r=me with comment fix up. > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:776 > + # but are not in RegisterSet::vmCalleeSaveRegisters() need to be saved here. > + # I.e.: Only those registers that are callee save in the C ABI, but are not > + # callee save in teh JIT ABI. nit: "here. I.e.: Only" -> "here i.e. only". /teh/the/
Geza Lore
Comment 3 2022-06-09 02:56:37 PDT
Created attachment 460118 [details] Patch
Geza Lore
Comment 4 2022-06-09 02:58:11 PDT
Created attachment 460119 [details] Patch
EWS
Comment 5 2022-06-09 04:30:53 PDT
Committed r295416 (251422@main): <https://commits.webkit.org/251422@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460119 [details].
Radar WebKit Bug Importer
Comment 6 2022-06-09 04:31:16 PDT
<rdar://problem/94713078>
Note You need to log in before you can comment on or make changes to this bug.