Bug 241342 – REGRESSION: [iOS] TestWebKitAPI.HSTS.ThirdParty is consistently failing

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

TestWebKitAPI.HSTS.ThirdParty
        
        /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:117
        Expected equality of these values:
          [webView _test_waitForAlert]
            Which is: " "
          "http://example.com/ hi"
        
        
        /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:118
        Expected equality of these values:
          httpServer.totalRequests()
            Which is: 1
          2u
            Which is: 2

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.HSTS.ThirdParty

[Radar WebKit Bug Importer]

<rdar://problem/94448628>

[Ryan Haddad]

This test makes requests to example.com, maybe it is the same as https://bugs.webkit.org/show_bug.cgi?id=241233?

[Karl Rackler]

I have disabled this test for iOS while this issue is investigated.

[Karl Rackler]

Pull request: https://github.com/WebKit/WebKit/pull/1392

[EWS]

Test gardening commit r295398 (251404@main): <https://commits.webkit.org/251404@main>

Reviewed commits have been landed. Closing PR #1392 and removing active labels.

[Alex Christensen]

Aha!  determineITPStateInternal is returning true on macOS and false on iOS, which causes ITP to be enabled by default on macOS but not iOS, which causes the HSTS mitigation to happen on macOS but not iOS.  The code is fine, the test needs to just enable ITP everywhere.

[Alex Christensen]

Created attachment 460136 [details]
Patch

[EWS]

Committed r295437 (251443@main): <https://commits.webkit.org/251443@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460136 [details].