Bug 241310

Summary:

[LFC][FFC] FlexLayout should only take logical values

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
[fast-cq]Patch	ews-feeder: commit-queue-

Description zalan 2022-06-04 16:26:53 PDT

ssia

Comment 1 zalan 2022-06-04 16:29:29 PDT

Created attachment 460031 [details]
Patch

Comment 2 zalan 2022-06-05 10:20:32 PDT

Created attachment 460040 [details]
[fast-cq]Patch

Comment 3 Antti Koivisto 2022-06-05 12:16:15 PDT

Comment on attachment 460040 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460040&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:84
> +    struct LogicalConstraints {
> +        std::optional<LayoutUnit> verticalSpace;
> +        std::optional<LayoutUnit> horizontalSpace;
> +    };

nice

Comment 4 EWS 2022-06-05 20:51:33 PDT

Committed r295276 (251322@main): <https://commits.webkit.org/251322@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460040 [details].

Comment 5 Radar WebKit Bug Importer 2022-06-05 20:52:13 PDT

<rdar://problem/94416379>