Bug 241310

Summary: [LFC][FFC] FlexLayout should only take logical values
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch ews-feeder: commit-queue-

zalan
Reported 2022-06-04 16:26:53 PDT
ssia
Attachments
Patch (9.64 KB, patch)
2022-06-04 16:29 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (9.69 KB, patch)
2022-06-05 10:20 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-06-04 16:29:29 PDT
Created attachment 460031 [details] Patch
zalan
Comment 2 2022-06-05 10:20:32 PDT
Created attachment 460040 [details] [fast-cq]Patch
Antti Koivisto
Comment 3 2022-06-05 12:16:15 PDT
Comment on attachment 460040 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460040&action=review > Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:84 > + struct LogicalConstraints { > + std::optional<LayoutUnit> verticalSpace; > + std::optional<LayoutUnit> horizontalSpace; > + }; nice
EWS
Comment 4 2022-06-05 20:51:33 PDT
Committed r295276 (251322@main): <https://commits.webkit.org/251322@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460040 [details].
Radar WebKit Bug Importer
Comment 5 2022-06-05 20:52:13 PDT
<rdar://problem/94416379>
Note You need to log in before you can comment on or make changes to this bug.