Bug 241304
| Summary: | Implement text-justify: none; | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 99945 | ||
Tim Nguyen (:ntim)
The original implementation for legacy layout in bug 135349 had the issue that it didn't take in account text-align-last: justify; (if text-align is different than justify).
IFC does not implement text-justify: none.
So I removed the existing legacy layout implementation of text-justify: none in https://github.com/WebKit/WebKit/pull/1308 to avoid confusion.
I think it should be easy to add support for both modern and legacy layouts, however it's probably worth refactoring to avoid duplicating the logic.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
One testcase that would be nice to add is:
text-align: end;
text-align-last: justify;
text-justify: none;
Currently, I think legacy layout handles this incorrectly, as the last line will still be justified.
Radar WebKit Bug Importer
<rdar://problem/94879056>
Alexsander Borges Damaceno
Pull request: https://github.com/WebKit/WebKit/pull/38054