Bug 241297
| Summary: | [PGO] WebKit always uses empty profiling data on release builds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> |
| Component: | WebKit Misc. | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | emw, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Wenson Hsieh
PROFILE_DATA_PATH_INTERNAL_YES = $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/Profiling/WebKit.profdata.compressed;
We're missing a `WebKitAdditions` in the release build path.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/1304
Wenson Hsieh
(In reply to Wenson Hsieh from comment #0)
> PROFILE_DATA_PATH_INTERNAL_YES =
> $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/Profiling/WebKit.
> profdata.compressed;
>
> We're missing a `WebKitAdditions` in the release build path.
(More specifically, this should be `…/WebKitAdditions/Profiling/WebKit`)
EWS
Committed r295259 (251305@main): <https://commits.webkit.org/251305@main>
Reviewed commits have been landed. Closing PR #1304 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/94376562>