Bug 241284
| Summary: | `git webkit setup` hard codes the path to Xcode in .git/hooks/pre-commit | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Tim Horton
I use many Xcodes, and frequently delete them; the hardcoded path in .git/hooks/pre-commit then needs to be updated (or `git webkit setup` re-run). Shouldn't this use xcrun, or something?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
We cannot just use xcrun, because this code is not Mac only. But it's not very clear to me why we cannot just use "git", and rely on the PATH.
Radar WebKit Bug Importer
<rdar://problem/94435371>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/1324
EWS
Committed r295288 (251334@main): <https://commits.webkit.org/251334@main>
Reviewed commits have been landed. Closing PR #1324 and removing active labels.