Bug 241284

Summary:	`git webkit setup` hard codes the path to Xcode in .git/hooks/pre-commit
Product:	WebKit	Reporter:	Tim Horton <thorton>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Description Tim Horton 2022-06-03 13:55:24 PDT

I use many Xcodes, and frequently delete them; the hardcoded path in .git/hooks/pre-commit then needs to be updated (or `git webkit setup` re-run). Shouldn't this use xcrun, or something?

Comment 1 Alexey Proskuryakov 2022-06-05 13:46:59 PDT

We cannot just use xcrun, because this code is not Mac only. But it's not very clear to me why we cannot just use "git", and rely on the PATH.

Comment 2 Radar WebKit Bug Importer 2022-06-06 07:27:05 PDT

<rdar://problem/94435371>

Comment 3 Jonathan Bedard 2022-06-06 07:29:44 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1324

Comment 4 EWS 2022-06-06 08:54:06 PDT

Committed r295288 (251334@main): <https://commits.webkit.org/251334@main>

Reviewed commits have been landed. Closing PR #1324 and removing active labels.