Bug 24128

Summary: Upstream more V8 custom bindings
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: WebCore Misc.Assignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Upstream move V8 custom bindings, v1 eric: review+

Description Dimitri Glazkov (Google) 2009-02-24 11:19:01 PST
Mostly uninteresting constructors and XSLTProcessor bits.
Comment 1 Dimitri Glazkov (Google) 2009-02-24 11:26:53 PST
Created attachment 27924 [details]
Upstream move V8 custom bindings, v1

 WebCore/ChangeLog                                  |   20 +++
 .../bindings/v8/custom/V8DOMParserConstructor.cpp  |   45 ++++++
 .../v8/custom/V8MessageChannelConstructor.cpp      |   77 ++++++++++
 .../v8/custom/V8WebKitCSSMatrixConstructor.cpp     |   66 +++++++++
 .../v8/custom/V8XMLSerializerConstructor.cpp       |   45 ++++++
 .../v8/custom/V8XPathEvaluatorConstructor.cpp      |   45 ++++++
 .../bindings/v8/custom/V8XSLTProcessorCustom.cpp   |  153 ++++++++++++++++++++
 7 files changed, 451 insertions(+), 0 deletions(-)
Comment 2 Eric Seidel (no email) 2009-02-24 11:56:27 PST
Comment on attachment 27924 [details]
Upstream move V8 custom bindings, v1

It looks fine so long as all your return v8:Undefined() calls have been checked to make sure they shouldn't be return doNotIntercept() or whatever the current name is.

Also, you're missing a newline at end of file in at least one file.
Comment 3 Dimitri Glazkov (Google) 2009-02-24 15:51:55 PST
Landed as http://trac.webkit.org/changeset/41186.