Bug 241251
| Summary: | SharedBuffer argument passed in the various Images class method should be const. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Images | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | NEW | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=241110 | ||
Jean-Yves Avenard [:jya]
In bug 241110 we had to use const_cast to take a strong reference on a SharedBuffer.
The various SharedBuffer received from networking are const, but Image related classes take a non-const SharedBuffer reference.
SharedBuffer is an immutable object, but passing the objects as const reference is the right thing to do.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/94324781>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/1350