Bug 24115

Summary: Introduce platform independent stubs for plugins
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kevino, vestbo
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Move wx plug-in stubs to common port independent stubs kevino: review+

Laszlo Gombos
Reported 2009-02-23 19:11:53 PST
I noticed that there are 2 implementations for plug-in stubs. One implementation is under WebCore/plugins/wx for the wx port and the other one is in the WebCore/platform/qt/TemporaryLinkStubs.cpp for certain the Qt ports. There is no reason why the stubs could not be shared between the wx and Qt ports and potentially used by other ports as well. The proposal is to promote the wx stubs to top level stubs to the WebCore/plugins directory - similarly as this has been handled for IconDatabase(None) and Threading(None). Patch will follow.
Attachments
Move wx plug-in stubs to common port independent stubs (19.40 KB, patch)
2009-02-23 19:19 PST, Laszlo Gombos 		kevino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-02-23 19:19:11 PST
Created attachment 27901 [details] Move wx plug-in stubs to common port independent stubs
Laszlo Gombos
Comment 2 2009-02-23 20:28:25 PST
(In reply to comment #1) > Created an attachment (id=27901) [review] > Move wx plug-in stubs to common port independent stubs I forget to mention that this just promotes the wx stubs to be port independent stubs. I intent to create another bug/patch to take advantage of this in the Qt build.
Kevin Ollivier
Comment 3 2009-03-18 09:35:32 PDT
Landed in r41786, thanks!
Note You need to log in before you can comment on or make changes to this bug.