Bug 241117
| Summary: | Control whether PDF.js is included via a build-time setting | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 235981 | ||
Elliott Williams
r289850 introduced PDF.js into WebCore, butit was reverted in r291241 due to its impact on bundle size. Let's find a way to reland the changes as an opt-in feature.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/94127873>
Tim Nguyen (:ntim)
It would be nice to reuse ENABLE(PDFJS) or ENABLE_PDFJS (and disable that option by default while we're there).
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/2006
Tim Nguyen (:ntim)
*** Bug 235981 has been marked as a duplicate of this bug. ***
EWS
Committed 252343@main (d4387ce981a9): <https://commits.webkit.org/252343@main>
Reviewed commits have been landed. Closing PR #2006 and removing active labels.