Summary: | [webkitpy] run-benchmark script fails to find the lsof command on Linux | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dewei_zhu, ews-watchlist, glenn, jbedard, lmoura, saam, slewis, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2022-05-29 14:28:39 PDT
Created attachment 459842 [details]
Patch
Comment on attachment 459842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459842&action=review Looks good. Minor suggestion inline. > Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:71 > + lsof_path = shutil.which('lsof') if shutil.which('lsof') else '/usr/sbin/lsof' Maybe `lsov_path = shutil.which('lsof') or '/usr/sbin/lsof'` to avoid the extra which call? (In reply to Lauro Moura from comment #2) > Comment on attachment 459842 [details] > > Maybe `lsov_path = shutil.which('lsof') or '/usr/sbin/lsof'` to avoid the > extra which call? Obviously, I meant `lsof_path = ...`. Comment on attachment 459842 [details]
Patch
r=me
(In reply to Lauro Moura from comment #2) > Maybe `lsov_path = shutil.which('lsof') or '/usr/sbin/lsof'` to avoid the > extra which call? Good idea, seems cleaner. I will land with this Created attachment 460226 [details]
Patch for landing
Committed r295520 (251525@main): <https://commits.webkit.org/251525@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460226 [details]. |