Bug 241057

Summary:

[LFC][FFC] Transition flex-grow computation to flex-basis based

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[fast-cq]Patch	ews-feeder: commit-queue-

zalan

Reported 2022-05-27 21:52:08 PDT

ssia

Attachments
[fast-cq]Patch (6.95 KB, patch) 2022-05-27 21:56 PDT, zalan	ews-feeder: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2022-05-27 21:56:13 PDT

Antti Koivisto

Comment 2 2022-05-27 22:07:02 PDT

Comment on attachment 459825 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459825&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:299 > + struct StrechingFlexItem { very similar to ShrinkingFlexItem

zalan

Comment 3 2022-05-28 07:54:02 PDT

(In reply to Antti Koivisto from comment #2) > Comment on attachment 459825 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459825&action=review > > > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:299 > > + struct StrechingFlexItem { > > very similar to ShrinkingFlexItem Yeah, they may converge soon.

EWS

Comment 4 2022-05-28 09:19:03 PDT

Committed r295000 (251098@main): <https://commits.webkit.org/251098@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459825 [details].

Radar WebKit Bug Importer

Comment 5 2022-05-28 09:20:14 PDT

Note You need to log in before you can comment on or make changes to this bug.