Bug 241023
| Summary: | REGRESSION(r294634): Fix unified build with ContentTypeUtilities.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aperez, eric.carlson, heycam, jer.noble, loic.yhuel, mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Olivier Blin
ContentTypeUtilities.cpp has been added in r294634, but it can break some unified builds because of such errors:
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-22.cpp:2:
In file included from ../../Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp:27:
In file included from ../../Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h:28:
In file included from ../../Source/WebCore/platform/graphics/FloatSize.h:30:
In file included from ../../Source/WebCore/platform/graphics/IntPoint.h:28:
../../Source/WebCore/platform/graphics/IntSize.h:212:16: error: no type named 'TextStream' in namespace 'WebCore::WTF'; did you mean simply 'TextStream'?
WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, const IntSize&);
^~~~~~~~~~~~~~~
TextStream
WTF/Headers/wtf/Forward.h:160:12: note: 'TextStream' declared here
using WTF::TextStream;
^
This is because it can make <wtf/Forward.h> included from the WebCore namespace.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Olivier Blin
Pull request: https://github.com/WebKit/WebKit/pull/1099
Radar WebKit Bug Importer
<rdar://problem/94347846>
Olivier Blin
Fixed by Cameron McCormack in https://commits.webkit.org/251669@main