Bug 240973

Summary:	Re-factoring clean up in allocateCell and tryAllocateCell.
Product:	WebKit	Reporter:	Mark Lam <mark.lam>
Component:	JavaScriptCore	Assignee:	Mark Lam <mark.lam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Mark Lam

Reported 2022-05-26 13:36:44 PDT

The AllocationFailureMode should be a template parameter to tryAllocateCellHelper because it's constant. Also, tryAllocateCellHelper should take a VM& instead of taking a Heap&, and then converting it back to a VM&.

Attachments
Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2022-05-26 13:40:24 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1067

EWS

Comment 2 2022-05-26 15:52:02 PDT

Committed r294905 (251028@main): <https://commits.webkit.org/251028@main> Reviewed commits have been landed. Closing PR #1067 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-05-26 15:53:14 PDT

<rdar://problem/94000566>

Note You need to log in before you can comment on or make changes to this bug.