Bug 240973 - Re-factoring clean up in allocateCell and tryAllocateCell.
Summary: Re-factoring clean up in allocateCell and tryAllocateCell.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-26 13:36 PDT by Mark Lam
Modified: 2022-05-26 15:53 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-05-26 13:36:44 PDT 
The AllocationFailureMode should be a template parameter to tryAllocateCellHelper because it's constant.  Also, tryAllocateCellHelper should take a VM& instead of taking a Heap&, and then converting it back to a VM&.
Comment 1 Mark Lam 2022-05-26 13:40:24 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1067
Comment 2 EWS 2022-05-26 15:52:02 PDT 
Committed r294905 (251028@main): <https://commits.webkit.org/251028@main>

Reviewed commits have been landed. Closing PR #1067 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-05-26 15:53:14 PDT 
<rdar://problem/94000566>