Bug 240889

Summary:

Interop 2021 some flex-aspect-ratio tests failing on wpt.fyi

Product:

WebKit

Reporter:

Sammy Gill <sgill26>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

changseok, dgrogan, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, rbuis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-

Sammy Gill

Reported 2022-05-24 15:35:37 PDT

There are a number of flex-aspect ratio tests failing on wpt.fyi. The following tests are failing: flex-aspect-ratio-002 flex-aspect-ratio-004 flex-aspect-ratio-025 flex-aspect-ratio-026 https://wpt.fyi/results/css/css-sizing/aspect-ratio?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2021-aspect-ratio

Attachments
Patch (2.07 KB, patch) 2022-07-27 02:14 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (2.91 KB, patch) 2022-07-27 06:41 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (8.99 KB, patch) 2022-07-28 07:11 PDT, Rob Buis	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-05-24 15:35:58 PDT

<rdar://problem/93862854>

Rob Buis

Comment 2 2022-06-24 04:56:38 PDT

If you intend to work on this, we could collaborate. I did some patches for two of these in the past: https://bugs.webkit.org/show_bug.cgi?id=222357

Rob Buis

Comment 3 2022-07-27 02:14:13 PDT

Created attachment 461240 [details] Patch

Rob Buis

Comment 4 2022-07-27 06:41:12 PDT

Created attachment 461242 [details] Patch

Rob Buis

Comment 5 2022-07-28 07:11:29 PDT

Created attachment 461270 [details] Patch

Sammy Gill

Comment 6 2022-08-02 15:46:39 PDT

Hi Rob, Which tests are your patches going to be addressing? I'm going to be starting work on the aspect-ratio issues again so I'll be making bug reports for each individual test.

David Grogan

Comment 7 2022-08-03 09:03:15 PDT

Note https://github.com/w3c/csswg-drafts/issues/6794 which may change flex + aspect-ratio behavior.

Rob Buis

Comment 8 2022-08-03 09:30:45 PDT

(In reply to Sammy Gill from comment #6) > Hi Rob, > > Which tests are your patches going to be addressing? I'm going to be > starting work on the aspect-ratio issues again so I'll be making bug reports > for each individual test. Great! I was investigating and I think most flexbox test failures are due to the same root cause, not doing the right calculation for the content size suggestion, this probably applies to flex-aspect-ratio-002|004|025 and maybe even 038/039. The test flex-aspect-ratio-026.html has the most problems. One problem will be fixed by https://bugs.webkit.org/show_bug.cgi?id=243321. A remaining problem is that the width of some of the divs is 5px too wide, causing the green block to not be continuous. The final problem is when resizing a window, two of the divs will keep getting wider. When I disabled caching of child intrinsic sizes it did not have this bug but I think there were other issues. Feel free to ping me now and then if needed, these failures are longstanding so it would be cool to see them fixed.

Note You need to log in before you can comment on or make changes to this bug.