Bug 240837

Summary:

Failing text-indent WPT tests

Product:

WebKit

Reporter:

Kiet Ho <kiet.ho>

Component:

CSS

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, koivisto, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[fast-cq]Patch	none

Kiet Ho

Reported 2022-05-23 16:03:17 PDT

imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-flex-item-001.html imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-grid-item-001.html

Attachments
[fast-cq]Patch (8.58 KB, patch) 2025-09-04 15:13 PDT, alan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2022-05-23 19:30:49 PDT

*** Bug 240838 has been marked as a duplicate of this bug. ***

Radar WebKit Bug Importer

Comment 2 2022-05-30 16:04:13 PDT

<rdar://problem/94123786>

Ahmad Saleem

Comment 3 2023-10-01 16:54:57 PDT

We are still failing these test case. I think in IFC, we might have to do something here? InlineFormattingGeometry::computedTextIndent to account for 'isGridItem()' or 'isFlexItemIncludingDeprecated()'?

alan

Comment 4 2023-10-01 17:09:26 PDT

(In reply to Ahmad Saleem from comment #3) > We are still failing these test case. I think in IFC, we might have to do > something here? > > InlineFormattingGeometry::computedTextIndent > > to account for 'isGridItem()' or 'isFlexItemIncludingDeprecated()'? Not quite, this is a bug in our "first formatted line" implementation where we assume the first child always produces a visible line (see setIsFirstChildForIntegration). Should be relatively easy to fix as we already have it working for text-box trim.

alan

Comment 5 2025-09-04 15:13:37 PDT

Created attachment 476642 [details] [fast-cq]Patch

Note You need to log in before you can comment on or make changes to this bug.