Bug 240837
| Summary: | Failing text-indent WPT tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kiet Ho <kiet.ho> |
| Component: | CSS | Assignee: | zalan <zalan> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kiet Ho
imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-flex-item-001.html
imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-grid-item-001.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
*** Bug 240838 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
<rdar://problem/94123786>
Ahmad Saleem
We are still failing these test case. I think in IFC, we might have to do something here?
InlineFormattingGeometry::computedTextIndent
to account for 'isGridItem()' or 'isFlexItemIncludingDeprecated()'?
zalan
(In reply to Ahmad Saleem from comment #3)
> We are still failing these test case. I think in IFC, we might have to do
> something here?
>
> InlineFormattingGeometry::computedTextIndent
>
> to account for 'isGridItem()' or 'isFlexItemIncludingDeprecated()'?
Not quite, this is a bug in our "first formatted line" implementation where we assume the first child always produces a visible line (see setIsFirstChildForIntegration). Should be relatively easy to fix as we already have it working for text-box trim.