Bug 240785
| Summary: | input[type=search] preferred content width should not include decorations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | Layout and Rendering | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, bugs-noreply, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Nguyen (:ntim)
The searchfield still allocates space for the search clear button due to CSS in themeAdwaita.css.
To fix this, styles added on ::-webkit-search-cancel-button from themeAdwaita.css need to be set by RenderThemeAdwaita.cpp instead in adjustSearchFieldCancelButtonStyle, notably width/height.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
actually there's a better fix
Radar WebKit Bug Importer
<rdar://problem/94113204>
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/1161
EWS
Committed 253595@main (5f2088ec9415): <https://commits.webkit.org/253595@main>
Reviewed commits have been landed. Closing PR #1161 and removing active labels.
EWS
Test gardening commit 253620@main (19719edc4942): <https://commits.webkit.org/253620@main>
Reviewed commits have been landed. Closing PR #3505 and removing active labels.
Dawn Morningstar
Re-opening for pull request https://github.com/apple/WebKit/pull/179