Bug 240776

Summary: [LFC][FFC] Add support for block direction grow
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2022-05-22 13:44:00 PDT
ssia
Attachments
Patch (5.24 KB, patch)
2022-05-22 13:48 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.23 KB, patch)
2022-05-22 15:43 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-05-22 13:48:32 PDT
Created attachment 459650 [details] Patch
zalan
Comment 2 2022-05-22 15:43:30 PDT
Created attachment 459653 [details] Patch
Antti Koivisto
Comment 3 2022-05-23 06:04:31 PDT
Comment on attachment 459653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459653&action=review > Source/WebCore/layout/formattingContexts/FormattingConstraints.h:69 > - unsigned m_baseTypeFlags : 2; // OptionSet<BaseTypeFlag> > + unsigned m_baseTypeFlags : 3; // OptionSet<BaseTypeFlag> unrelated?
zalan
Comment 4 2022-05-23 06:19:25 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 459653 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459653&action=review > > > Source/WebCore/layout/formattingContexts/FormattingConstraints.h:69 > > - unsigned m_baseTypeFlags : 2; // OptionSet<BaseTypeFlag> > > + unsigned m_baseTypeFlags : 3; // OptionSet<BaseTypeFlag> > > unrelated? yea from https://trac.webkit.org/changeset/294623/webkit/trunk/Source/WebCore/layout/formattingContexts/FormattingConstraints.h
EWS
Comment 5 2022-05-23 06:49:13 PDT
Committed r294638 (250862@main): <https://commits.webkit.org/250862@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459653 [details].
Radar WebKit Bug Importer
Comment 6 2022-05-23 06:50:16 PDT
<rdar://problem/93756160>
Note You need to log in before you can comment on or make changes to this bug.