Bug 240776 - [LFC][FFC] Add support for block direction grow
Summary: [LFC][FFC] Add support for block direction grow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-22 13:44 PDT by zalan
Modified: 2022-05-23 06:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.24 KB, patch)
2022-05-22 13:48 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (5.23 KB, patch)
2022-05-22 15:43 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-05-22 13:44:00 PDT
ssia
Comment 1 zalan 2022-05-22 13:48:32 PDT
Created attachment 459650 [details]
Patch
Comment 2 zalan 2022-05-22 15:43:30 PDT
Created attachment 459653 [details]
Patch
Comment 3 Antti Koivisto 2022-05-23 06:04:31 PDT
Comment on attachment 459653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459653&action=review

> Source/WebCore/layout/formattingContexts/FormattingConstraints.h:69
> -    unsigned m_baseTypeFlags : 2; // OptionSet<BaseTypeFlag>
> +    unsigned m_baseTypeFlags : 3; // OptionSet<BaseTypeFlag>

unrelated?
Comment 4 zalan 2022-05-23 06:19:25 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 459653 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459653&action=review
> 
> > Source/WebCore/layout/formattingContexts/FormattingConstraints.h:69
> > -    unsigned m_baseTypeFlags : 2; // OptionSet<BaseTypeFlag>
> > +    unsigned m_baseTypeFlags : 3; // OptionSet<BaseTypeFlag>
> 
> unrelated?
yea from https://trac.webkit.org/changeset/294623/webkit/trunk/Source/WebCore/layout/formattingContexts/FormattingConstraints.h
Comment 5 EWS 2022-05-23 06:49:13 PDT
Committed r294638 (250862@main): <https://commits.webkit.org/250862@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459653 [details].
Comment 6 Radar WebKit Bug Importer 2022-05-23 06:50:16 PDT
<rdar://problem/93756160>