Bug 240650 – Missing JSCInlines.h header for non-unified 2.36.2 build

• Component: WebKitGTK
• Status: ASSIGNED

[Dennis Nezic]

These files seem to be missing  #include "JSCInlines.h"

Source/JavaScriptCore/dfg/DFGCapabilities.cpp
Source/JavaScriptCore/jit/JITDisassembler.cpp
Source/JavaScriptCore/jit/JITPlan.cpp
Source/JavaScriptCore/llint/LLIntEntrypoint.cpp
Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.cpp
Source/JavaScriptCore/wasm/js/WebAssemblyFunctionBase.cpp

The compilation/linking errors look like:

Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGCapabilities.cpp.o: in function `JSC::DFG::capabilityLevel(JSC::CodeBlock*)':
DFGCapabilities.cpp:(.text+0x4ea): undefined reference to `JSC::JSCell::structure() const

[Adrian Perez]

(In reply to Dennis Nezic from comment #0)
> These files seem to be missing  #include "JSCInlines.h"
> 
> Source/JavaScriptCore/dfg/DFGCapabilities.cpp
> Source/JavaScriptCore/jit/JITDisassembler.cpp
> Source/JavaScriptCore/jit/JITPlan.cpp
> Source/JavaScriptCore/llint/LLIntEntrypoint.cpp
> Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.cpp
> Source/JavaScriptCore/wasm/js/WebAssemblyFunctionBase.cpp
> 
> The compilation/linking errors look like:
> 
> Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGCapabilities.cpp.
> o: in function `JSC::DFG::capabilityLevel(JSC::CodeBlock*)':
> DFGCapabilities.cpp:(.text+0x4ea): undefined reference to
> `JSC::JSCell::structure() const

Could you share the CMake invocation you are using? I have tried the
following but have not been able to reproduce the issue:

  cmake -Bbuild -S. -DPORT=GTK -DENABLE_UNIFIED_BUILDS=OFF -GNinja
  ninja -Cbuild

If you could also indicate if you are defining CFLAGS, CXXFLAGS, LDFLAGS,
and/or CPPFLAGS in the environment when running CMake, that may help us
reproduce and fix your issue.

[Adrian Perez]

FWIW, we just released version 2.36.3 which includes a flurry of
build fixes. You may want to try it instead:

  https://webkitgtk.org/2022/05/28/webkitgtk2.36.3-released.html

[Dennis Nezic]

Same issue with 2.36.3. I'm assuming you tested with DENABLE_UNIFIED_BUILDS=no ?

[Dennis Nezic]

Err, woops, ofc you did. Any tips on how I can figure out which other -DENABLE flag might be causing this? Maybe it's my -DENABLE_VIDEO=no

[Dennis Nezic]

Ie. to clarify / rephrase the question, where is that undefined reference to JSC::JSCell supposed to have been included/defined? Ie. where was it included/defined during YOUR compilation?

[Adrian Perez]

(In reply to Dennis Nezic from comment #4)
> Err, woops, ofc you did. Any tips on how I can figure out which other
> -DENABLE flag might be causing this? Maybe it's my -DENABLE_VIDEO=no

It's quite likely this. Thanks for mentioning it, I will do a test build
with video support disabled and fix any issues found with that configuration.
For the record, we do not officially support building with ENABLE_VIDEO
disabled; but when issues appear with it disabled appear we do try to fix
them in a best-effort basis -- so thanks for reporting the issue!

[Michael Catanzaro]

(In reply to Adrian Perez from comment #6)
> For the record, we do not officially support building with ENABLE_VIDEO
> disabled; but when issues appear with it disabled appear we do try to fix
> them in a best-effort basis -- so thanks for reporting the issue!

Bug #241128

[Adrian Perez]

(In reply to Adrian Perez from comment #6)
> (In reply to Dennis Nezic from comment #4)
> > Err, woops, ofc you did. Any tips on how I can figure out which other
> > -DENABLE flag might be causing this? Maybe it's my -DENABLE_VIDEO=no
> 
> It's quite likely this. Thanks for mentioning it, I will do a test build
> with video support disabled and fix any issues found with that configuration.
> For the record, we do not officially support building with ENABLE_VIDEO
> disabled; but when issues appear with it disabled appear we do try to fix
> them in a best-effort basis -- so thanks for reporting the issue!

So I tried -DENABLE_VIDEO=OFF and also a different build adding
the -DENABLE_WEB_RTC=OFF option using 2.36.3, but I could not
reproduce your build issue.

Could you please share your full CMake invocation, indicate what
is your target hardware, and whether you are cross-compiling WebKit
or not?

[Dennis Nezic]

(In reply to Michael Catanzaro from comment #7)
> (In reply to Adrian Perez from comment #6)
> > For the record, we do not officially support building with ENABLE_VIDEO
> > disabled; but when issues appear with it disabled appear we do try to fix
> > them in a best-effort basis -- so thanks for reporting the issue!
> 
> Bug #241128

Hm. Youtube doesn't work at all (not even to read/post comments) without ENABLE_VIDEO? https://imgur.com/a/Qznz74j (ie. all the greyed-out boxes.) Sigh.