Bug 240613

Summary: REGRESSION(r294317): Broke multiple layout-tests and 2 API-tests for iOS.
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: jenner, kkinnunen, Morningstar, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=240551
https://bugs.webkit.org/show_bug.cgi?id=240616
Bug Depends on:    
Bug Blocks: 240452    
Attachments:
Description Flags
REVERT of r294317 Morningstar: commit-queue+

WebKit Commit Bot
Reported 2022-05-18 17:01:49 PDT
https://commits.webkit.org/r294317 introduced a regression: Broke multiple layout-tests and 2 API-tests for iOS. This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
REVERT of r294317 (11.15 KB, patch)
2022-05-18 17:01 PDT, WebKit Commit Bot 		Morningstar: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2022-05-18 17:01:58 PDT
Created attachment 459561 [details] REVERT of r294317 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Radar WebKit Bug Importer
Comment 2 2022-05-18 17:06:15 PDT
<rdar://problem/93537869>
Dawn Morningstar
Comment 3 2022-05-18 17:09:25 PDT
Closed before patch landed... reopening
Kimmo Kinnunen
Comment 4 2022-05-19 06:07:02 PDT
Do you remember which tests were broken?
Robert Jenner
Comment 5 2022-05-19 12:50:15 PDT
The tests that broke this this were the following: Layout-Tests: editing/input/cocoa/autocorrect-off.html editing/input/cocoa/autocorrect-on.html editing/undo-manager/undo-manager-item-labels.html fast/forms/ios/autocapitalize-words.html fast/forms/ios/form-control-refresh/select/select-multiple-picker.html fast/forms/ios/inputmode-none.html fast/forms/ios/no-scrolling-when-moving-focus-between-adjacent-fields.html fast/forms/validation-messages.html fast/forms/datalist/datalist.html fast/forms/ios/inputmode-removing-none.html fast/events/ios/do-not-show-keyboard-when-focusing-after-blur.html fast/events/ios/keyup.html fast/events/ios/unscalable-viewport-clicks-on-doubletap.html fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-shadow-tree.html http/wpt/webauthn/public-key-credential-unfocused-document.https.html mathml/fractions-invalid.html API-Tests: TestWebKitAPI.DragAndDropTests.CanDragImageWhenNotFirstResponder TestWebKitAPI.DragAndDropTests.InjectedBundleImageElementData
Alexey Proskuryakov
Comment 6 2022-05-19 19:39:09 PDT
The revert was landed here: Committed r294452 (250720@trunk): <https://commits.webkit.org/250720@trunk>
Note You need to log in before you can comment on or make changes to this bug.