Bug 240577

Summary: Remove unused memory capacity output value in calculateURLCacheSizes
Product: WebKit Reporter: Olivier Blin <olivier.blin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, cgarcia, darin, ggaren, kkinnunen, loic.yhuel, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+, achristensen: commit-queue-

Olivier Blin
Reported 2022-05-18 06:50:27 PDT
calculateURLCacheSizes() had a urlCacheMemoryCapacity output value since its creation in r203857, which was passed to platformSetURLCacheSize(). But the implementation has been removed for the soup platform in r205556 when switching to the WebKit network cache, and for the Cocoa platform in r232201 when dropping NSURLCache support. urlCacheMemoryCapacity is now unused.
Attachments
Patch (4.20 KB, patch)
2022-05-18 06:53 PDT, Olivier Blin 		achristensen: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Olivier Blin
Comment 1 2022-05-18 06:53:07 PDT
Created attachment 459539 [details] Patch
Alex Christensen
Comment 2 2022-05-18 09:35:19 PDT
Comment on attachment 459539 [details] Patch r=me I think this needs a COMMIT_MESSAGE which is uploaded automatically with webkit-patch upload after you commit locally with git.
Olivier Blin
Comment 3 2022-05-19 01:23:55 PDT
Pull request: https://github.com/WebKit/WebKit/pull/771
EWS
Comment 4 2022-05-19 20:47:20 PDT
Committed r294527 (250782@main): <https://commits.webkit.org/250782@main> Reviewed commits have been landed. Closing PR #771 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2022-05-19 20:48:13 PDT
<rdar://problem/93626827>
Note You need to log in before you can comment on or make changes to this bug.