Bug 240543
| Summary: | [Python3] Fix Tools/Scripts/check-for-invalid-symbols-in-version-script | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=237442 | ||
Adrian Perez
Traceback (most recent call last):
File "/app/webkit/Tools/Scripts/check-for-invalid-symbols-in-version-script", line 33, in <module>
if symbol not in data:
TypeError: a bytes-like object is required, not 'str'
---
As with other recent examples we need to decode the bytes objects
returned by reading from the popen stream into strings (see the fix
for “check-for-global-bss-symbols-in-webkitgtk-libs”, bug #237442,
for an example of a similar fix)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/699
EWS
Committed r294358 (250663@main): <https://commits.webkit.org/250663@main>
Reviewed commits have been landed. Closing PR #699 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/93460708>