Bug 240492

Summary:	Use ASCIILiteral for JSC::HashTableValue::m_key
Product:	WebKit	Reporter:	Chris Dumez <cdumez>
Component:	JavaScriptCore	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Chris Dumez

Reported 2022-05-16 16:47:37 PDT

Use ASCIILiteral for JSC::HashTableValue::m_key since the key is always a string literal. This allows JSC::reifyStaticProperties() to call a more optimal Identifier::fromString(VM&, ASCIILiteral) overload.

Attachments
Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2022-05-16 19:03:07 PDT

Pull request: https://github.com/WebKit/WebKit/pull/660

EWS

Comment 2 2022-05-17 14:24:54 PDT

Committed r294346 (250658@main): <https://commits.webkit.org/250658@main> Reviewed commits have been landed. Closing PR #660 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-05-17 14:25:13 PDT

<rdar://problem/93452636>

Note You need to log in before you can comment on or make changes to this bug.