Bug 240483

Summary: Private relay should fail closed for third party loads if the main resource was loaded over private relay
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 240740    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
reverting patch
none
Patch none

Alex Christensen
Reported 2022-05-16 15:21:03 PDT
Private relay should fail closed for third party loads if the main resource was loaded over private relay
Attachments
Patch (8.42 KB, patch)
2022-05-16 15:25 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (8.25 KB, patch)
2022-05-17 15:19 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
reverting patch (6.86 KB, patch)
2022-05-20 15:40 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.44 KB, patch)
2022-05-20 20:23 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-05-16 15:25:37 PDT
Created attachment 459458 [details] Patch
Alex Christensen
Comment 2 2022-05-16 15:25:41 PDT
<rdar://problem/92697007>
Alex Christensen
Comment 3 2022-05-17 15:19:28 PDT
Created attachment 459518 [details] Patch
EWS
Comment 4 2022-05-17 17:56:41 PDT
Committed r294371 (250670@main): <https://commits.webkit.org/250670@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459518 [details].
WebKit Commit Bot
Comment 5 2022-05-20 15:13:14 PDT
Re-opened since this is blocked by bug 240740
Alex Christensen
Comment 6 2022-05-20 15:40:37 PDT
Created attachment 459629 [details] reverting patch
Alex Christensen
Comment 7 2022-05-20 20:23:12 PDT
Created attachment 459635 [details] Patch
Alex Christensen
Comment 8 2022-05-23 09:38:56 PDT
I verified that, when opening several news sites, the patch from 5/17 had some differences between whether it calls _setPrivacyProxyFailClosedForUnreachableNonMainHosts on requests to the same hosts, which would cause different TCP connections to be made, which explains the performance regression. I verified that the patch from 5/20 does not do this.
Chris Dumez
Comment 9 2022-05-23 09:41:39 PDT
Comment on attachment 459635 [details] Patch r=me
EWS
Comment 10 2022-05-24 12:36:10 PDT
Committed r294757 (250925@main): <https://commits.webkit.org/250925@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459635 [details].
Note You need to log in before you can comment on or make changes to this bug.