Bug 240453

Summary: [WPE] Use new libwpe API to synchronise display refreshes fully to the screen refresh rate
Product: WebKit Reporter: Chris Lord <clord>
Component: WPE WebKitAssignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, cmarcelo, ews-watchlist, gyuyoung.kim, kkinnunen, koivisto, luiz, ryuan.choi, sabouhallawa, sergio, thorton, zeno
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=240470
https://bugs.webkit.org/show_bug.cgi?id=242593
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Lord
Reported 2022-05-16 05:28:55 PDT
In ThreadedDisplayRefreshMonitor there's a FIXME to use the correct frame-rate for the DisplayUpdate object used for DisplayRefreshMonitor::displayDidRefresh - https://github.com/WebPlatformForEmbedded/libwpe/pull/104 adds API in libwpe to query/track the current display refresh that we can use for this.
Attachments
Patch (14.36 KB, patch)
2022-05-16 07:46 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (14.36 KB, patch)
2022-05-17 01:27 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (14.44 KB, patch)
2022-05-17 02:29 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2022-05-16 07:46:44 PDT
Created attachment 459424 [details] Patch
Adrian Perez
Comment 2 2022-05-16 14:32:26 PDT
In bug #240470 there is a patch to add a newer version of libwpe to the Flatpak SDK which includes the needed API. Once that lands and an update to the SDK is pushed, the EWS builds will notice and build the code guarded with WPE_CHECK_VERSION()
Adrian Perez
Comment 3 2022-05-16 14:35:33 PDT
Comment on attachment 459424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459424&action=review > Source/WebKit/UIProcess/API/wpe/WPEView.cpp:124 > +#if WPE_CHECK_VERSION(1, 13, 0) You'll want to change this to check for 1.13.2 before landing, which is the version adding the new API: https://wpewebkit.org/release/libwpe-1.13.2.html :)
Chris Lord
Comment 4 2022-05-17 01:27:28 PDT
Created attachment 459489 [details] Patch
Chris Lord
Comment 5 2022-05-17 02:29:20 PDT
Created attachment 459492 [details] Patch
EWS
Comment 6 2022-05-17 06:23:59 PDT
Committed r294322 (250642@main): <https://commits.webkit.org/250642@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459492 [details].
Note You need to log in before you can comment on or make changes to this bug.