Bug 240452

Summary: ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: CanvasAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jenner, kkinnunen, Morningstar, rackler, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 240613    
Bug Blocks: 240417, 240495    
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2022-05-16 05:26:12 PDT
ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone
Attachments
Patch (13.55 KB, patch)
2022-05-16 05:40 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2022-05-16 05:40:24 PDT
Created attachment 459417 [details] Patch
EWS
Comment 2 2022-05-17 02:48:43 PDT
Committed r294317 (250637@main): <https://commits.webkit.org/250637@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459417 [details].
Radar WebKit Bug Importer
Comment 3 2022-05-17 02:49:13 PDT
<rdar://problem/93412550>
Karl Rackler
Comment 4 2022-05-17 17:08:21 PDT
*** Bug 240495 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 5 2022-05-18 17:01:51 PDT
Re-opened since this is blocked by bug 240613
Dawn Morningstar
Comment 6 2022-05-18 17:07:42 PDT
Reverted here https://bugs.webkit.org/show_bug.cgi?id=240613 because this patch caused numerous layout-test failures/timeouts and two api test failures: https://bugs.webkit.org/show_bug.cgi?id=240551
Robert Jenner
Comment 7 2022-05-18 17:42:37 PDT
Reverted r294317 for reason: Broke multiple layout-tests, and 2 api-tests. Committed r294452 (250720@trunk): <https://commits.webkit.org/250720@trunk>
Robert Jenner
Comment 8 2022-05-19 12:49:59 PDT
The tests that broke this this were the following: Layout-Tests: editing/input/cocoa/autocorrect-off.html editing/input/cocoa/autocorrect-on.html editing/undo-manager/undo-manager-item-labels.html fast/forms/ios/autocapitalize-words.html fast/forms/ios/form-control-refresh/select/select-multiple-picker.html fast/forms/ios/inputmode-none.html fast/forms/ios/no-scrolling-when-moving-focus-between-adjacent-fields.html fast/forms/validation-messages.html fast/forms/datalist/datalist.html fast/forms/ios/inputmode-removing-none.html fast/events/ios/do-not-show-keyboard-when-focusing-after-blur.html fast/events/ios/keyup.html fast/events/ios/unscalable-viewport-clicks-on-doubletap.html fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-shadow-tree.html http/wpt/webauthn/public-key-credential-unfocused-document.https.html mathml/fractions-invalid.html API-Tests: TestWebKitAPI.DragAndDropTests.CanDragImageWhenNotFirstResponder TestWebKitAPI.DragAndDropTests.InjectedBundleImageElementData
Kimmo Kinnunen
Comment 9 2023-02-22 07:07:21 PST
Pull request: https://github.com/WebKit/WebKit/pull/10515
EWS
Comment 10 2023-02-23 01:26:26 PST
Committed 260734@main (0072dcd9a13b): <https://commits.webkit.org/260734@main> Reviewed commits have been landed. Closing PR #10515 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.