Bug 240442

Summary: [LFC][FFC] Add support for logical ordering
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

zalan
Reported 2022-05-15 21:44:21 PDT
order property
Attachments
Patch (4.16 KB, patch)
2022-05-15 21:48 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (4.16 KB, patch)
2022-05-16 06:09 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.72 KB, patch)
2022-05-16 09:36 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.72 KB, patch)
2022-05-16 09:53 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-05-15 21:48:08 PDT
Created attachment 459389 [details] Patch
zalan
Comment 2 2022-05-16 06:09:31 PDT
Created attachment 459419 [details] Patch
zalan
Comment 3 2022-05-16 09:36:18 PDT
Created attachment 459429 [details] Patch
Antti Koivisto
Comment 4 2022-05-16 09:46:50 PDT
Comment on attachment 459429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459429&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:170 > + std::sort(logicalFlexItemList.begin(), logicalFlexItemList.end(), [&] (auto& a, auto& b) { Probably std::stable_sort? Otherwise identical items get ordered randomly.
zalan
Comment 5 2022-05-16 09:53:12 PDT
(In reply to Antti Koivisto from comment #4) > Comment on attachment 459429 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459429&action=review > > > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:170 > > + std::sort(logicalFlexItemList.begin(), logicalFlexItemList.end(), [&] (auto& a, auto& b) { > > Probably std::stable_sort? Otherwise identical items get ordered randomly. good point!
zalan
Comment 6 2022-05-16 09:53:27 PDT
Created attachment 459432 [details] Patch
EWS
Comment 7 2022-05-16 10:36:51 PDT
Committed r294240 (250598@main): <https://commits.webkit.org/250598@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459432 [details].
Radar WebKit Bug Importer
Comment 8 2022-05-16 10:37:23 PDT
<rdar://problem/93355697>
Note You need to log in before you can comment on or make changes to this bug.