Bug 240421

Summary: MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf, youssefdevelops, y_soliman
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2022-05-14 11:28:24 PDT
MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers
Attachments
Patch (6.73 KB, patch)
2022-05-14 11:40 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-05-14 11:30:19 PDT
<rdar://93279260>
youenn fablet
Comment 2 2022-05-14 11:40:01 PDT
Created attachment 459358 [details] Patch
Eric Carlson
Comment 3 2022-05-15 20:47:00 PDT
Comment on attachment 459358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459358&action=review > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150 > + Ref<MockAudioSharedInternalUnitState> m_isProducingState; Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`?
youenn fablet
Comment 4 2022-05-15 23:25:17 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 459358 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459358&action=review > > > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150 > > + Ref<MockAudioSharedInternalUnitState> m_isProducingState; > > Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`? Let's do that in a follow-up on GitHub, bugzilla webkit patch infra has some issues.
EWS
Comment 5 2022-05-16 00:27:34 PDT
Committed r294223 (250581@main): <https://commits.webkit.org/250581@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459358 [details].
Note You need to log in before you can comment on or make changes to this bug.