Bug 240421 - MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers
Summary: MockAudioSharedInternalUnit should exit early when being stopped in generateS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-14 11:28 PDT by youenn fablet
Modified: 2022-05-16 00:27 PDT (History)
12 users (show)

See Also:

Attachments
Patch (6.73 KB, patch)
2022-05-14 11:40 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-05-14 11:28:24 PDT 
MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers
Comment 1 youenn fablet 2022-05-14 11:30:19 PDT 
<rdar://93279260>
Comment 2 youenn fablet 2022-05-14 11:40:01 PDT 
Created attachment 459358 [details]
Patch
Comment 3 Eric Carlson 2022-05-15 20:47:00 PDT 
Comment on attachment 459358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459358&action=review

> Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150
> +    Ref<MockAudioSharedInternalUnitState> m_isProducingState;

Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`?
Comment 4 youenn fablet 2022-05-15 23:25:17 PDT 
(In reply to Eric Carlson from comment #3)
> Comment on attachment 459358 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459358&action=review
> 
> > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150
> > +    Ref<MockAudioSharedInternalUnitState> m_isProducingState;
> 
> Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`?

Let's do that in a follow-up on GitHub, bugzilla webkit patch infra has some issues.
Comment 5 EWS 2022-05-16 00:27:34 PDT 
Committed r294223 (250581@main): <https://commits.webkit.org/250581@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459358 [details].