Bug 240421 – MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers

[youenn fablet]

<rdar://93279260>

[youenn fablet]

Created attachment 459358 [details]
Patch

[Eric Carlson]

Comment on attachment 459358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459358&action=review

> Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150
> +    Ref<MockAudioSharedInternalUnitState> m_isProducingState;

Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`?

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 459358 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459358&action=review
> 
> > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150
> > +    Ref<MockAudioSharedInternalUnitState> m_isProducingState;
> 
> Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`?

Let's do that in a follow-up on GitHub, bugzilla webkit patch infra has some issues.

[EWS]

Committed r294223 (250581@main): <https://commits.webkit.org/250581@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459358 [details].