Summary: | MediaPlayer should cache plug-in proxy | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Carlson
2009-02-19 14:05:56 PST
Created attachment 27817 [details]
proposed patch
Comment on attachment 27817 [details] proposed patch > Index: WebCore/platform/graphics/MediaPlayer.cpp > =================================================================== > +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO) > + virtual void setPoster(const String&) { } setPoster(const String& /*url*/) would be slightly clearer. > Index: WebCore/platform/graphics/MediaPlayer.h > =================================================================== > --- WebCore/platform/graphics/MediaPlayer.h (revision 41083) > +++ WebCore/platform/graphics/MediaPlayer.h (working copy) > @@ -149,6 +149,9 @@ private: > bool m_visible; > float m_rate; > float m_volume; > +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO) > + WebMediaPlayerProxy* m_playerProxy; > +#endif Maybe add a comment to say that m_playerProxy is not owned and where it comes from? Committed revision 41118. |