Summary: | ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, benjamin, cdumez, cmarcelo, dino, ews-watchlist, hi, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Tim Horton
2022-05-13 16:48:10 PDT
Created attachment 459329 [details]
Patch
Created attachment 459333 [details]
Patch
Comment on attachment 459333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459333&action=review r=me > Source/WTF/wtf/cocoa/FileSystemCocoa.mm:241 > + static NeverDestroyed<RetainPtr<NSString>> path = adoptNS([^{ Why use adoptNS() + copy? Can we just assign the NSString* to the RetainPtr<> right away? (In reply to Chris Dumez from comment #4) > Comment on attachment 459333 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459333&action=review > > r=me > > > Source/WTF/wtf/cocoa/FileSystemCocoa.mm:241 > > + static NeverDestroyed<RetainPtr<NSString>> path = adoptNS([^{ > > Why use adoptNS() + copy? Can we just assign the NSString* to the > RetainPtr<> right away? I ... did not look at the code I was moving. That is weird, I agree!! Created attachment 459335 [details]
Patch
Created attachment 459345 [details]
Patch
Committed r294188 (250554@main): <https://commits.webkit.org/250554@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459345 [details]. |