Bug 240404

Summary: ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cmarcelo, dino, ews-watchlist, hi, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2022-05-13 16:48:10 PDT
ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS
Attachments
Patch (7.34 KB, patch)
2022-05-13 16:48 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (7.33 KB, patch)
2022-05-13 17:07 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (7.30 KB, patch)
2022-05-13 18:00 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (7.30 KB, patch)
2022-05-13 21:37 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2022-05-13 16:48:36 PDT
Created attachment 459329 [details] Patch
Tim Horton
Comment 2 2022-05-13 16:48:39 PDT
<rdar://problem/93070349>
Tim Horton
Comment 3 2022-05-13 17:07:29 PDT
Created attachment 459333 [details] Patch
Chris Dumez
Comment 4 2022-05-13 17:12:06 PDT
Comment on attachment 459333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459333&action=review r=me > Source/WTF/wtf/cocoa/FileSystemCocoa.mm:241 > + static NeverDestroyed<RetainPtr<NSString>> path = adoptNS([^{ Why use adoptNS() + copy? Can we just assign the NSString* to the RetainPtr<> right away?
Tim Horton
Comment 5 2022-05-13 17:40:34 PDT
(In reply to Chris Dumez from comment #4) > Comment on attachment 459333 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459333&action=review > > r=me > > > Source/WTF/wtf/cocoa/FileSystemCocoa.mm:241 > > + static NeverDestroyed<RetainPtr<NSString>> path = adoptNS([^{ > > Why use adoptNS() + copy? Can we just assign the NSString* to the > RetainPtr<> right away? I ... did not look at the code I was moving. That is weird, I agree!!
Tim Horton
Comment 6 2022-05-13 18:00:51 PDT
Created attachment 459335 [details] Patch
Tim Horton
Comment 7 2022-05-13 21:37:59 PDT
Created attachment 459345 [details] Patch
EWS
Comment 8 2022-05-13 23:16:02 PDT
Committed r294188 (250554@main): <https://commits.webkit.org/250554@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459345 [details].
Note You need to log in before you can comment on or make changes to this bug.