Summary: | [Repaint] Border ignores currentColor change when hovering | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, hi, koivisto, kondapallykalyan, mifenton, mmaxfield, ntim, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
zalan
2022-05-13 15:27:52 PDT
Created attachment 459328 [details]
Patch
Created attachment 459337 [details]
Patch
Is bug 223654 a duplicate? Comment on attachment 459337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459337&action=review > LayoutTests/ChangeLog:12 > + * fast/repaint/repaint-current-color-border-on-hover-expected.txt: Added. > + * fast/repaint/repaint-current-color-border-on-hover.html: Added. > + * fast/repaint/repaint-pseudo-border-on-hover-expected.txt: Added. > + * fast/repaint/repaint-pseudo-border-on-hover.html: Added. > + These files are not in the patch (In reply to Tim Nguyen (:ntim) from comment #4) > Comment on attachment 459337 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459337&action=review > > > LayoutTests/ChangeLog:12 > > + * fast/repaint/repaint-current-color-border-on-hover-expected.txt: Added. > > + * fast/repaint/repaint-current-color-border-on-hover.html: Added. > > + * fast/repaint/repaint-pseudo-border-on-hover-expected.txt: Added. > > + * fast/repaint/repaint-pseudo-border-on-hover.html: Added. > > + > > These files are not in the patch oops Comment on attachment 459337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459337&action=review > Source/WebCore/rendering/style/BorderData.h:114 > + return !currentColorDiffers || (m_top.color().isValid() && m_right.color().isValid() && m_bottom.color().isValid() && m_left.color().isValid()); Might be more stylish to use RenderStyle::isCurrentColor(m_top.color()) etc. Created attachment 459355 [details]
Patch
(In reply to zalan from comment #5) > (In reply to Tim Nguyen (:ntim) from comment #4) > > Comment on attachment 459337 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=459337&action=review > > > > > LayoutTests/ChangeLog:12 > > > + * fast/repaint/repaint-current-color-border-on-hover-expected.txt: Added. > > > + * fast/repaint/repaint-current-color-border-on-hover.html: Added. > > > + * fast/repaint/repaint-pseudo-border-on-hover-expected.txt: Added. > > > + * fast/repaint/repaint-pseudo-border-on-hover.html: Added. > > > + > > > > These files are not in the patch > oops webkit-patch land is messing with my local state. Committed r294195 (250561@main): <https://commits.webkit.org/250561@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459355 [details]. *** Bug 223654 has been marked as a duplicate of this bug. *** |