Bug 240362

Summary: Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2022-05-12 16:12:52 PDT
Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
Attachments
Patch (11.88 KB, patch)
2022-05-12 16:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (13.95 KB, patch)
2022-05-13 10:13 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (14.49 KB, patch)
2022-05-17 13:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (14.53 KB, patch)
2022-05-17 14:47 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (16.04 KB, patch)
2022-05-26 17:41 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-05-12 16:14:34 PDT
Created attachment 459256 [details] Patch
Alex Christensen
Comment 2 2022-05-13 10:13:37 PDT
Created attachment 459309 [details] Patch
Alex Christensen
Comment 3 2022-05-16 09:30:48 PDT
Perf testers say this is a 0.57% performance improvement.
Chris Dumez
Comment 4 2022-05-16 09:32:10 PDT
Comment on attachment 459309 [details] Patch r=me
EWS
Comment 5 2022-05-16 09:50:36 PDT
Committed r294238 (250596@main): <https://commits.webkit.org/250596@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459309 [details].
Radar WebKit Bug Importer
Comment 6 2022-05-16 09:51:13 PDT
<rdar://problem/93352198>
Ryan Haddad
Comment 7 2022-05-16 14:37:09 PDT
Reverted r294238 for reason: Breaks internal builds Committed r294261 (250609@trunk): <https://commits.webkit.org/250609@trunk>
Alex Christensen
Comment 8 2022-05-17 13:55:09 PDT
Created attachment 459513 [details] Patch
Alex Christensen
Comment 9 2022-05-17 14:47:20 PDT
Created attachment 459516 [details] Patch
Alex Christensen
Comment 10 2022-05-26 17:41:05 PDT
Created attachment 459800 [details] Patch
EWS
Comment 11 2022-05-26 20:51:12 PDT
Committed r294927 (251038@main): <https://commits.webkit.org/251038@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459800 [details].
Note You need to log in before you can comment on or make changes to this bug.