Bug 24036

Summary: Keyboard events need disambiguation on the Linux platform too.
Product: WebKit Reporter: Avi Drissman <avi>
Component: PlatformAssignee: Avi Drissman <avi>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac. eric: review+

Avi Drissman
Reported 2009-02-19 11:51:07 PST
Linux (in all its flavors) needs the same disambiguation of events as the Mac does (see plat/gtk/KeyEventGtk.cpp, plat/qt/PlatformKeyboardEventQt.cpp, and plat/wx/KeyboardEventWc.cpp).
Attachments
Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac. (1.87 KB, patch)
2009-02-19 11:51 PST, Avi Drissman 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Avi Drissman
Comment 1 2009-02-19 11:51:59 PST
Created attachment 27805 [details] Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac.
Avi Drissman
Comment 2 2009-02-19 11:52:27 PST
See http://codereview.chromium.org/21514 .
Eric Seidel (no email)
Comment 3 2009-02-19 14:27:33 PST
Comment on attachment 27805 [details] Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac. Looks fine to me.
Darin Fisher (:fishd, Google)
Comment 4 2009-02-20 07:34:58 PST
Landed as http://trac.webkit.org/changeset/41106
Note You need to log in before you can comment on or make changes to this bug.