Bug 240347
| Summary: | [WPE][GTK] Drop libnotify | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=180813 https://bugs.webkit.org/show_bug.cgi?id=243255 |
||
Michael Catanzaro
Currently WPE has no support for desktop notifications.
GTK supports desktop notifications via libnotify, but this library has been deprecated for a very long time. We should switch to GNotification. This will finally support WPE, too.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
(In reply to Michael Catanzaro from comment #0)
> We should switch to GNotification.
So I tried this today, but turns out the API is very awkward to use. Patrick suggests using the notifications portal D-Bus API directly. It's probably a smarter approach.
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/3040
EWS
Committed 253179@main (95858e6cc2e3): <https://commits.webkit.org/253179@main>
Reviewed commits have been landed. Closing PR #3040 and removing active labels.