Bug 240319

Summary: TextBoxPainter::paintForeground: painting text with no marking/decoration should be simple
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

zalan
Reported 2022-05-11 15:24:42 PDT
ssia
Attachments
Patch (6.14 KB, patch)
2022-05-11 15:32 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.13 KB, patch)
2022-05-12 06:37 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.19 KB, patch)
2022-05-12 13:38 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.19 KB, patch)
2022-05-12 15:30 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-05-11 15:32:01 PDT
Created attachment 459185 [details] Patch
Simon Fraser (smfr)
Comment 2 2022-05-11 15:37:37 PDT
Comment on attachment 459185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459185&action=review > Source/WebCore/rendering/TextBoxPainter.cpp:191 > + , StyledMarkedText::computeStyleForUnmarkedMarkedText(m_renderer, lineStyle, m_isFirstLine, m_paintInfo) }); comma on previous line
zalan
Comment 3 2022-05-12 06:37:31 PDT
Created attachment 459225 [details] Patch
zalan
Comment 4 2022-05-12 13:38:30 PDT
Created attachment 459247 [details] Patch
zalan
Comment 5 2022-05-12 15:30:14 PDT
Created attachment 459253 [details] Patch
EWS
Comment 6 2022-05-12 17:32:42 PDT
Committed r294128 (250505@main): <https://commits.webkit.org/250505@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459253 [details].
Radar WebKit Bug Importer
Comment 7 2022-05-12 17:33:17 PDT
<rdar://problem/93212498>
Note You need to log in before you can comment on or make changes to this bug.