Bug 240318

Summary: [WebAuthn] Clean up WebAuthenticationModern and WebAuthnProcess
Product: WebKit Reporter: pascoe <pascoe>
Component: WebKit Misc.Assignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=239073
Attachments:
Description Flags
Patch bfulgham: review+, ews-feeder: commit-queue-

pascoe@apple.com
Reported 2022-05-11 14:45:21 PDT
These are no longer necessary for ToT. Previously landed in https://bugs.webkit.org/show_bug.cgi?id=239073, but was rolled out.
Attachments
Patch (229.00 KB, patch)
2022-05-11 14:54 PDT, pascoe@apple.com
bfulgham: review+
ews-feeder: commit-queue-
Radar WebKit Bug Importer
Comment 1 2022-05-11 14:45:41 PDT
pascoe@apple.com
Comment 2 2022-05-11 14:54:50 PDT
Brent Fulgham
Comment 3 2022-05-12 09:54:01 PDT
Comment on attachment 459183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459183&action=review So much cleanup! r=me > Tools/ChangeLog:-1977 > - (TestWebKitAPI::WebCore::webAuthenticationModernExperimentalFeature): Deleted. We don't need this ChangeLog comment removal > Tools/ChangeLog:2011 > + (TestWebKitAPI::WebCore::webAuthenticationModernExperimentalFeature): Deleted. This seems to be in the wrong part of the file (is perhaps a dupe of the 5/11 comment) > Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:-1437 > -} Are these two tests really not needed anymore? It doesn't seem like disallowing the local authenticator is specifically related to the WebAuthn process, is it?
Brent Fulgham
Comment 4 2022-05-12 09:55:18 PDT
It doesn't seem like the Mac-AS-debug-wk2 failures are related. I have re-ran them.
pascoe@apple.com
Comment 5 2022-05-12 10:08:06 PDT
(In reply to Brent Fulgham from comment #3) > > Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:-1437 > > -} > > Are these two tests really not needed anymore? It doesn't seem like > disallowing the local authenticator is specifically related to the WebAuthn > process, is it? These tests are from when the WebAuthenticationPanel used a UI delegate method (decidePolicyForLocalAuthenticator) to ask if using the platform authenticator is permitted. This is superseded by requestLAContextForUserVerification, which effectively does the same thing, but does not return ExceptionData { UnknownError, "Disallow local authenticator."_s } (the standard request cancelled error is used).
pascoe@apple.com
Comment 6 2022-05-18 13:30:15 PDT
EWS
Comment 7 2022-05-18 14:59:13 PDT
Committed r294438 (250716@main): <https://commits.webkit.org/250716@main> Reviewed commits have been landed. Closing PR #744 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.