Summary: | TextBoxPainter::paintBackground should bail out early when nothing to paint | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, heycam, kangil.han, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
zalan
2022-05-11 14:23:16 PDT
Created attachment 459182 [details]
Patch
Created attachment 459184 [details]
Patch
Comment on attachment 459182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459182&action=review > Source/WebCore/rendering/TextBoxPainter.cpp:140 > + if (m_document.hasHighlightRegister()) Maybe "has highlight register and has a non-zero number of highlights"? Created attachment 459203 [details]
Patch
Comment on attachment 459203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459203&action=review > Source/WebCore/dom/Document.cpp:2891 > + return (m_highlightRegister && !m_highlightRegister->isEmpty()) || (m_fragmentHighlightRegister && !m_fragmentHighlightRegister->isEmpty()) I'd wrap the || ... onto a new line, indented. > Source/WebCore/dom/Document.cpp:2893 > + || (m_appHighlightRegister && m_appHighlightRegister->isEmpty()) Indent this line Created attachment 459204 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 459203 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459203&action=review > > > Source/WebCore/dom/Document.cpp:2891 > > + return (m_highlightRegister && !m_highlightRegister->isEmpty()) || (m_fragmentHighlightRegister && !m_fragmentHighlightRegister->isEmpty()) > > I'd wrap the || ... onto a new line, indented. > > > Source/WebCore/dom/Document.cpp:2893 > > + || (m_appHighlightRegister && m_appHighlightRegister->isEmpty()) > > Indent this line oops Created attachment 459205 [details]
Patch
Committed r294099 (250484@main): <https://commits.webkit.org/250484@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459205 [details]. *** Bug 239986 has been marked as a duplicate of this bug. *** |